Angular standalone sample updates #7547
Open
+22
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eugeno
requested review from
jo-arroyo,
tnorling and
peterzenz
as code owners
github-actions
bot
added
the
samples
|
@microsoft-github-policy-service agree |
|
Reminder: This PR appears to be stale. If this PR is still a work in progress please mark as draft. |
microsoft-github-policy-service
bot
added
the
Needs: Attention 👋
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
CommonModulestyleUrlinstead ofstyleUrlsinjectfor DItakeUntilDestroyedinstead ofSubject/OnDestroyapproachThere is a typing issue, which is now solved by a generic in the following line:
I found a fix in the next PR: #7484
After its merge, the generic can be removed: